[DT-1171] Add auth domain to snapshot access #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
fb-dt-1171-auth-domain-snapshot-access
|
| Run status |
|
| Run duration | 02m 55s |
| Commit |
|
| Committer | fboulnois |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
fboulnois
force-pushed
the
fb-dt-1171-auth-domain-snapshot-access
branch
2 times, most recently
from
e0dedb4 to
3becb79
Compare
fboulnois
commented
Feb 6, 2025
fboulnois
force-pushed
the
fb-dt-1171-auth-domain-snapshot-access
branch
3 times, most recently
from
bb8fe49 to
6ddcf7d
Compare
fboulnois
requested review from
rushtong and
pshapiro4broad
and removed request for
a team
pshapiro4broad
approved these changes
Feb 10, 2025
fboulnois
force-pushed
the
fb-dt-1171-auth-domain-snapshot-access
branch
2 times, most recently
from
1fe919e to
479a999
Compare
fboulnois
force-pushed
the
fb-dt-1171-auth-domain-snapshot-access
branch
from
479a999 to
3bda864
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1171
Summary of changes
Testing Strategy
Unit tests and created snapshots with auth domains manually.